Skip to content

test-child-process-pipe-dataflow failing on Windows #48300

Closed
Closed
test-child-process-pipe-dataflow failing on Windows#48300
Labels
flaky-testIssues and PRs involving tests that fail intermittently in CI.windowsIssues and PRs related to the Windows platform.

Description

@aduh95
aduh95
opened on Jun 2, 2023
not ok 106 parallel/test-child-process-pipe-dataflow
  ---
  duration_ms: 221.12800
  severity: fail
  exitcode: 1
  stack: |-
    node:assert:125
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
    + actual - expected
    
    + '130086'
    - '1048577'
        at process.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-child-process-pipe-dataflow.js:71:12)
        at process.emit (node:events:523:35) {
      generatedMessage: true,
      code: 'ERR_ASSERTION',
      actual: '130086',
      expected: '1048577',
      operator: 'strictEqual'
    }
    
    Node.js v21.0.0-pre
  ...

It's also failing on v16.x-staging, so I don't think it's related to a recent change on main, maybe a change with the infra?

Activity

  1. aduh95 commented on Jun 2, 2023

    @aduh95
    aduh95
    on Jun 2, 2023
    ContributorAuthor

    Examples:

  2. aduh95 commented on Jun 2, 2023

    @aduh95
    aduh95
    on Jun 2, 2023
    ContributorAuthor

    /cc @nodejs/platform-windows @nodejs/build

  3. aduh95
    added
    windowsIssues and PRs related to the Windows platform.
    flaky-testIssues and PRs involving tests that fail intermittently in CI.
    on Jun 2, 2023

  4. MoLow commented on Jun 4, 2023

    @MoLow
    MoLow
    on Jun 4, 2023
    Member

    I am investigating on https://ci.nodejs.org/computer/test-azure_msft-win11_vs2022-arm64-3/

  5. richardlau commented on Jun 5, 2023

    @richardlau
    richardlau
    on Jun 5, 2023
    Member

    It's also failing on v16.x-staging, so I don't think it's related to a recent change on main, maybe a change with the infra?

    Looking at the Node.js 16 daily builds, the first failure there appears to be https://ci.nodejs.org/view/Node.js%20Daily/job/node-daily-v16.x-staging/36/, i.e. https://ci.nodejs.org/job/node-test-binary-windows-js-suites/21215/. Those failures happened on:

    According to #48331, the test is failing due to a difference in behaviour of wc. I believe wc is coming from git.

    Looking at the prior windows-update-reboot run before those jobs we can see that git was updated
    e.g. https://ci.nodejs.org/manage/computer/test-azure_msft-win10_vs2019-x64-4/builds
    https://ci.nodejs.org/job/windows-update-reboot/label=test-azure_msft-win10_vs2019-x64-4/2370/consoleFull

    09:00:37 
09:00:37 You have git v2.40.1 installed. Version 2.41.0 is available based on your source(s).
09:00:53 
Progress: Downloading git.install 2.41.0... %
...
Progress: Downloading git.install 2.41.0... 100%
09:00:56 
09:00:56 git.install v2.41.0 [Approved]
09:00:56 git.install package files upgrade completed. Performing other installation steps.
09:00:57 Using Git LFS
09:00:57 Installing 64-bit git.install...
09:01:28 git.install has been installed.
09:01:28 git.install installed to 'C:\Program Files\Git'
09:01:28   git.install can be automatically uninstalled.
09:01:29  The upgrade of git.install was successful.
09:01:29   Software installed to 'C:\Program Files\Git\'
09:01:33 
Progress: Downloading git 2.41.0... 62%
Progress: Downloading git 2.41.0... 100%
09:01:33 
09:01:33 git v2.41.0 [Approved]
09:01:33 git package files upgrade completed. Performing other installation steps.
09:01:33  The upgrade of git was successful.
09:01:33   Software installed to 'C:\ProgramData\chocolatey\lib\git'
09:01:34 git.install v2.41.0 is the latest version available based on your source(s).

    (Similarly https://ci.nodejs.org/job/windows-update-reboot/label=test-rackspace-win2012r2_vs2017-x64-4/2370/consoleFull for the other machine.)

  6. bricss commented on Jun 5, 2023

    @bricss
    bricss
    on Jun 5, 2023
    Contributor

    It's might be due to latest Git 64-bit version switch to Cygwin v3.4.0 -> https://gitforwindows.org/32-bit.html

  7. lpinca commented on Jun 6, 2023

    @lpinca
    lpinca
    on Jun 6, 2023
    Member

    I can confirm that the issue is caused by Git for Windows v2.41.0. With v2.40.0 the test passes locally.

  8. richardlau commented on Jun 14, 2023

    @richardlau
    richardlau
    on Jun 14, 2023
    Member

    Probably related to git-for-windows/git#4464

  9. lpinca commented on Jun 23, 2023

    @lpinca
    lpinca
    on Jun 23, 2023
    Member

    I've also seen test-child-process-stdio-reuse-readable-stdio fail recently on Windows and I think the underlying issue is the same.

  10. lpinca
    added a commit that references this issue on Jun 24, 2023

    test: mark test-child-process-stdio-reuse-readable-stdio flaky

    90f4bb1
  11. nodejs-github-bot
    added a commit that references this issue on Jun 25, 2023

    test: mark test-child-process-stdio-reuse-readable-stdio flaky

    c308054
  12. juanarbol
    added a commit that references this issue on Jun 29, 2023

    test: mark test-child-process-stdio-reuse-readable-stdio flaky

    5daa07a
  13. RafaelGSS
    added a commit that references this issue on Jul 3, 2023

    test: mark test-child-process-stdio-reuse-readable-stdio flaky

    0f912a7
  14. juanarbol
    added a commit that references this issue on Jul 4, 2023

    test: mark test-child-process-stdio-reuse-readable-stdio flaky

    2edd0fd
  15. richardlau
    added a commit that references this issue on Jul 11, 2023

    test: mark test-child-process-stdio-reuse-readable-stdio flaky

    859aa87

  16. lpinca commented on Aug 14, 2023

    @lpinca
    lpinca
    on Aug 14, 2023
    Member

    The upstream issue was closed without a fix.

  17. Ceres6
    added 2 commits that reference this issue on Aug 14, 2023

    test: mark test-child-process-stdio-reuse-readable-stdio flaky

    5f92b46

    test: mark test-child-process-stdio-reuse-readable-stdio flaky

    4339923

  18. joyeecheung commented on Sep 8, 2023

    @joyeecheung
    joyeecheung
    on Sep 8, 2023
    Member

    It's almost constantly failing now, perhaps we should just skip it on Windows until it's properly fixed to at least give the CI some green space..

  19. nodejs-github-bot
    added a commit that references this issue on Sep 11, 2023

    test: skip test-child-process-pipe-dataflow.js on Windows

    b0edb28
  20. ruyadorno
    added a commit that references this issue on Sep 28, 2023

    test: skip test-child-process-pipe-dataflow.js on Windows

    667a924
  21. abhishekumar-tyagi
    added a commit that references this issue on May 5, 2024

    test: mark test-child-process-stdio-reuse-readable-stdio flaky

    f42996e

  22. StefanStojanovic commented on May 27, 2025

    @StefanStojanovic
    StefanStojanovic
    on May 27, 2025
    Contributor

    This hasn't failed recently. Closing it, as the issue in Git was closed, and we mitigated it on our side. If needed, please reopen.

  23. StefanStojanovic
    closed this as completedon May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    flaky-testIssues and PRs involving tests that fail intermittently in CI.windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions