test_runner: incorrect test:pass & test:fail events description, 'duration' instead of 'duration_ms'

Affected URL(s)

https://nodejs.org/dist/latest/docs/api/test.html

Description of the problem

Docs:

Reality:

Lines 712 to 720 in 6c08b1f

    
           report() { 
        
             countCompletedTest(this); 
        
             if (this.subtests.length > 0) { 
        
               this.reporter.plan(this.subtests[0].nesting, kFilename, this.subtests.length); 
        
             } else { 
        
               this.reportStarted(); 
        
             } 
        
             let directive; 
        
             const details = { __proto__: null, duration_ms: this.#duration() };

@types/node also contains wrong object shape.

@MoLow

@MoLow I am new to this project and would like to work on this issue.

The best thing to do is to open a PR fixing the documentation

@MoLow

hi @MoLow I want to take this, I have a question for more clarity on this, the expected result is whether should we use 'duration' or 'duration_ms' for the test cases on [node/lib/internal/test_runner/test.js] ?

the code emits duration_ms, but documentation mentions duration

hi, i'am already working on that. please help to review :) thank you

@0xArdi-N nice work. just a friendly reminder that you should wait for other people who have already been working on this issue before you make a PR.

@heysujal

@heysujal thank you sujal :)

doc: change duration to duration_ms on test documentation

Navigation Menu

Repository navigation

test_runner: incorrect test:pass & test:fail events description, 'duration' instead of 'duration_ms' #48887

Affected URL(s)

Description of the problem

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	report() {
	countCompletedTest(this);
	if (this.subtests.length > 0) {
	this.reporter.plan(this.subtests[0].nesting, kFilename, this.subtests.length);
	} else {
	this.reportStarted();
	}
	let directive;
	const details = { __proto__: null, duration_ms: this.#duration() };

test_runner: incorrect test:pass & test:fail events description, 'duration' instead of 'duration_ms' #48887

Description

Affected URL(s)

Description of the problem

Activity

heysujal commented on Jul 23, 2023

MoLow commented on Jul 23, 2023

arxngr commented on Jul 23, 2023

MoLow commented on Jul 23, 2023

arxngr commented on Jul 23, 2023

heysujal commented on Jul 23, 2023

arxngr commented on Jul 23, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions