http.Agent keepAlive connection pooling broken #52299

Activity

1. isker commented on Apr 1, 2024

   

   isker

   on Apr 1, 2024

   Contributor

   More actions

   The behavior you’re reporting makes sense to me as you’re not consuming the response body of the first request (the first argument to the callback, which you are not using) before making the second.

   👍React with 👍1Reacted by KaKa

   😄React with 😄1Reacted by Matt Weber
2. Malikrehman00107 commented on Apr 1, 2024

   

   Malikrehman00107

   on Apr 1, 2024

   More actions

   const http = require("http");
   
   http.globalAgent = new http.Agent({ keepAlive: true });
   
   const host = "www.neverssl.com";
   const port = 80;
   const method = 'GET';
   
   http.get("http://www.neverssl.com", function(response1) {
     console.log("1 done");
     response1.resume(); // Consume the response body of the first request
     setTimeout(function () {
       http.get("http://www.neverssl.com", function(response2) {
         console.log("2 done");
         response2.resume(); // Consume the response body of the second request
         process._getActiveHandles().forEach(function(h, idx) {
           if(h.localAddress) {
             console.log({
               idx: idx,
               destroyed: h.destroyed,
               localPort: h.localPort,
               remoteAddress: h.remoteAddress,
               remotePort: h.remotePort
             });
           }
         });
       });
     }, 1000);
   });
   
   

   By calling the resume() method on the http.IncomingMessage objects (response1 and response2), you ensure that the response bodies are consumed, allowing the connections to be reused properly. This should result in only one socket being open at the conclusion of the second request.
3. mweberxyz commented on Apr 1, 2024

   

   mweberxyz

   on Apr 1, 2024

   Author

   More actions

   Thx @isker and @Malikrehman00107, my mistake.
4. mweberxyz

   closed this as completedon Apr 1, 2024