Skip to content

assert.deepEqual loops forever with circular refs #6416

Closed
Closed
assert.deepEqual loops forever with circular refs#6416
Labels
assertIssues and PRs related to the assert subsystem.confirmed-bugIssues and PRs for confirmed bugs.

Description

@kuraga
kuraga
opened on Apr 27, 2016

Version: v4.4.3

Platform: Linux 3.13.0-24-generic #47-Ubuntu SMP Fri May 2 23:30:00 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux

Code:

var assert = require('assert');

var b = {};
b.b = b;

var c = {};
c.b = c;

assert.deepEqual(b, c);

Expected: no exceptions.

Actual: RangeError: Maximum call stack size exceeded

See also:

Activity

  1. addaleax
    added
    assertIssues and PRs related to the assert subsystem.
    on Apr 27, 2016

  2. Trott commented on Apr 27, 2016

    @Trott
    Trott
    on Apr 27, 2016
    Member

    Also affects deepStrictEqual().

  3. Trott commented on Apr 27, 2016

    @Trott
    Trott
    on Apr 27, 2016
    Member

    Judging from the test, this is sort of by design. The original behavior was (apparently) to loop forever but now it throws an error instead.

    Should be fixable by keeping track of seen references. Not sure about the semver implications or if the Locked status of the API is an issue here or not. (I would consider this a bugfix myself, but others may disagree.)

  4. addaleax commented on Apr 27, 2016

    @addaleax
    addaleax
    on Apr 27, 2016
    Member

    @Trott I’ve looked a bit at the original issue linked above, and I think Ryan Dahl actually just forgot to pull in the patch which does what you suggest (nodejs/node-v0.x-archive#207 (comment)). Would say it’s a bugfix, too.

  5. Trott commented on Apr 27, 2016

    @Trott
    Trott
    on Apr 27, 2016
    Member

    @addaleax Cool! I think I've got a fix almost ready to go, but if you're already working on it, I'm happy to drop it and go do something else.

  6. addaleax commented on Apr 27, 2016

    @addaleax
    addaleax
    on Apr 27, 2016
    Member

    @Trott No, sorry, didn’t mean to imply that I was coding anything right now – go ahead! 😄

  7. Fishrock123
    added
    confirmed-bugIssues and PRs for confirmed bugs.
    on Apr 29, 2016
  8. Trott
    added a commit that references this issue on Apr 29, 2016

    assert: allow circular references

    d3aafd0
  9. Trott
    closed this as completedin d3aafd0on Apr 29, 2016
  10. Fishrock123
    added a commit that references this issue on May 4, 2016

    assert: allow circular references

    76c9ab5
  11. joelostrowski
    added a commit that references this issue on May 4, 2016

    assert: allow circular references

    46acf73
  12. azu
    added 2 commits that reference this issue on May 6, 2016

    feat(assert): Allow circular references

    e11a573

    feat(assert): Allow circular references

    4183bf4
  13. MylesBorins
    added 6 commits that reference this issue on Jul 11, 2016

    assert: allow circular references

    431b615

    assert: allow circular references

    23726c8

    assert: allow circular references

    323e9cd

    assert: allow circular references

    ab6eeda

    assert: allow circular references

    d7b13f2

    assert: allow circular references

    39e2474
  14. josephg
    added a commit that references this issue on Mar 31, 2017

    assert: var -> const and added tests

    d6baaee
  15. jasnell
    added 2 commits that reference this issue on Jun 2, 2017

    assert: fix deepEqual RangeError: Maximum call stack size exceeded

    b1ed55f

    assert: fix deepEqual RangeError: Maximum call stack size exceeded

    47c9de9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    assertIssues and PRs related to the assert subsystem.confirmed-bugIssues and PRs for confirmed bugs.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions