Skip to content

[tools] update cpplint.py #7444

Closed
Closed
[tools] update cpplint.py#7444
Labels
toolsIssues and PRs related to the tools directory.

Description

@trevnorris
trevnorris
opened on Jun 27, 2016
  • Version: master
  • Platform: all
  • Subsystem: tools

The file tools/cpplint.py needs to be updated with the latest (https://raw.githubusercontent.com/google/styleguide/gh-pages/cpplint/cpplint.py). Reason is because some header information has changed that's causing lint errors for c++11 specific code. Specifically that std::swap() used to be in <algorithm> but since c++11 is now in <utility>.

The file will need to be updated, and all previous patches will need to be reapplied. The later is the difficult part, and my python isn't up to snuff to deal with them.

Activity

  1. trevnorris
    added
    toolsIssues and PRs related to the tools directory.
    on Jun 27, 2016

  2. MylesBorins commented on Jun 27, 2016

    @MylesBorins
    MylesBorins
    on Jun 27, 2016
    Contributor

    I'd be up for taking a dig into it. @trevnorris do we have any idea how many patches there are?

  3. addaleax commented on Jun 27, 2016

    @addaleax
    addaleax
    on Jun 27, 2016
    Member
    $ git log --pretty=oneline tools/cpplint.py
bb33c28e2141a1eabdff753e6717f5aea5866146 tools: disable readability/function cpplint rule
3eff42bbca531873905ef4478e8d6ec9a7485d3a tools: reduce verbosity of cpplint
813e73e1f5fa0cfa357164138e3d52acab508718 tools: list missing whitespace/if-one-line cpplint
7b4516356a1c72b08d9c4eb7ad1d25a1804cbe62 tools: add tap output to cpplint
a493dab2e72d19ddd226cd2094463ddb2354af06 cpplint: make it possible to run outside git repo
7861ff47285084604963a9f269b6062a23acd8a2 test: create test-ci, modify test-all, fix cpplint
2bc30f239be3e56d642eda38df98c656d55b4d86 cpplint: disallow if one-liners
7063c59b97fa4f365f9e5ec1f563235ede4104db cpplint: disallow comma-first in C++
98c54246c208698ded4c88abd37bb75b926d687d tools: cpplint: fix NOLINT(build/include_order)
847c6d980c83274b6c37e29a07d19a696435588b tools: cpplint: fix up build/include_order rule
3c6b5d5df1e445d080737e435675e11b102f0126 cpplint: make lint rules closer to node's source
3058f08e645bca41ee0f281ed83a697be1e3c8c4 tools: remove unnecessary cpplint rules
ac58d3a6653425cb625684bc6ffc38ecc89646c8 Import  cpplint.py

    Seems like all of these except for the first one are from us?

  4. bnoordhuis commented on Jun 28, 2016

    @bnoordhuis
    bnoordhuis
    on Jun 28, 2016
    Member

    I'll have a stab at this.

  5. bnoordhuis commented on Jun 28, 2016

    @bnoordhuis
    bnoordhuis
    on Jun 28, 2016
    Member

    #7462

  6. bnoordhuis
    closed this as completedin #7462on Jun 29, 2016

  7. trevnorris commented on Jun 29, 2016

    @trevnorris
    trevnorris
    on Jun 29, 2016
    ContributorAuthor

    Yey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    toolsIssues and PRs related to the tools directory.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions