Repository navigation
Conversation
Member
|
v9.x-staging fails because #17704 is not in it. Is it possible to include it in this PR? |
Member
Author
|
Not sure. That's a semver-major pr so would need a semver-major minor backport that omitted the breaking bits. That would best be done in a separate PR. |
Member
|
Could this commit be further backported to 8 in case? |
Member
Author
|
That's going to require a bit more work. Planning to do it later this week |
MylesBorins
force-pushed
the
v9.x-staging
branch
from
January 9, 2018 08:20
bd744b1 to
f55a5e8
Compare
MylesBorins
force-pushed
the
backport-http2-v9.x
branch
from
January 9, 2018 08:23
bf3c880 to
512fa41
Compare
Contributor
|
I've rebased against the new v9.x-staging to remove a commit that was breaking the build, it looks like another commit may be breaking stuff so i'll likely rebase one more time 😄 |
Member
|
@MylesBorins you are looking for #17800 which depends on #17704 |
Backport of multiple http2 related commits to v9.x-staging.
Currently blocked by #18049 and whatever else is currently causing v9.x-staging to fail. Will be able to finish once v9.x-staging is functioning again.
Note: have not fully tested this yet because of the v9.x-staging breakage.
Ping @nodejs/http2 @mcollina
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http2