Skip to content

http2: backport changes to v9.x-staging - #18050

Closed
jasnell wants to merge 27 commits into
nodejs:v9.x-stagingfrom
jasnell:backport-http2-v9.x
Closed

jasnell wants to merge 27 commits into
nodejs:v9.x-stagingfrom
jasnell:backport-http2-v9.x

Conversation

@jasnell

@jasnell jasnell commented Jan 9, 2018

Copy link
Copy Markdown
Member

Backport of multiple http2 related commits to v9.x-staging.

Currently blocked by #18049 and whatever else is currently causing v9.x-staging to fail. Will be able to finish once v9.x-staging is functioning again.

Note: have not fully tested this yet because of the v9.x-staging breakage.

Ping @nodejs/http2 @mcollina

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. v9.x labels Jan 9, 2018
@jasnell jasnell changed the title Backport http2 v9.x http2: backport changes to v9.x-staging Jan 9, 2018
@jasnell jasnell added dont-land-on-v4.x http2 Issues and PRs related to the http2 subsystem. blocked PRs that are blocked by other issues or PRs. labels Jan 9, 2018
@targos

targos commented Jan 9, 2018

Copy link
Copy Markdown
Member

v9.x-staging fails because #17704 is not in it. Is it possible to include it in this PR?

@jasnell

jasnell commented Jan 9, 2018

Copy link
Copy Markdown
Member Author

Not sure. That's a semver-major pr so would need a semver-major minor backport that omitted the breaking bits. That would best be done in a separate PR.

@mcollina

mcollina commented Jan 9, 2018

Copy link
Copy Markdown
Member

Could this commit be further backported to 8 in case?

@jasnell

jasnell commented Jan 9, 2018

Copy link
Copy Markdown
Member Author

That's going to require a bit more work. Planning to do it later this week

@MylesBorins

Copy link
Copy Markdown
Contributor

I've rebased against the new v9.x-staging to remove a commit that was breaking the build, it looks like another commit may be breaking stuff so i'll likely rebase one more time 😄

@targos

targos commented Jan 9, 2018

Copy link
Copy Markdown
Member

@MylesBorins you are looking for #17800 which depends on #17704