Skip to content

test: replace s_client in test-https-ci-reneg-attack - #25720

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:rm-client-https
Closed

test: replace s_client in test-https-ci-reneg-attack#25720
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:rm-client-https

Conversation

@Trott

@Trott Trott commented Jan 26, 2019

Copy link
Copy Markdown
Member

Replace s_client in test-https-ci-reneg-attack with built-in
client calling tls.renegotiate(). This also fixes the currently-broken
test. (It is broken due to a change in behavior in a
recently-updated-in-core version of s_client.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
test: replace s_client in test-https-ci-reneg-attack
b2ad179 
Replace `s_client` in test-https-ci-reneg-attack with built-in
client calling `tls.renegotiate()`. This also fixes the currently-broken
test. (It is broken due to a change in behavior in a
recently-updated-in-core version of `s_client`.)
@nodejs-github-bot

nodejs-github-bot commented Jan 26, 2019

Copy link
Copy Markdown
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2398/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Jan 26, 2019
@Trott

Trott commented Jan 26, 2019

Copy link
Copy Markdown
Member Author

Pummel tests are not run in regular CI so this combination should be sufficient:

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2398/

Repurposed custom-suites job from node-daily-master that runs the pummel tests, but set to only run this one (because there is one other broken pummel test fixed in another PR that hasn't landed yet): https://ci.nodejs.org/job/node-test-commit-custom-suites/841/

@Trott Trott added the flaky-test Issues and PRs involving tests that fail intermittently in CI. label Jan 26, 2019
This was referenced Jan 26, 2019
Closed
Closed
Closed
bnoordhuis
bnoordhuis approved these changes Jan 26, 2019
View reviewed changes
Comment thread test/pummel/test-https-ci-reneg-attack.js
});
const options = {
rejectUnauthorized: false,
agent

@bnoordhuis bnoordhuis Jan 26, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a trailing comma?

@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 26, 2019
@Trott