Skip to content

http: align OutgoingMessage and ClientRequest destroy - #32148

Closed
ronag wants to merge 9 commits into
nodejs:masterfrom
nxtedition:http-client-destroy4
Closed

http: align OutgoingMessage and ClientRequest destroy#32148
ronag wants to merge 9 commits into
nodejs:masterfrom
nxtedition:http-client-destroy4

Conversation

@ronag

@ronag ronag commented Mar 8, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Added .destroyed property to OutgoingMessage and ClientRequest
to align with streams.

Fixed ClientRequest.destroy to dump res and re-use socket in agent
pool aligning it with abort.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@addaleax addaleax addaleax approved these changes
@jasnell jasnell Awaiting requested review from jasnell
+1 more reviewer
@szmarczak szmarczak szmarczak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. http Issues and PRs related to the http subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ronag @nodejs-github-bot @szmarczak @codecov-io @mcollina @addaleax