build: update macos deployment target to 10.13 for 14.x by AshCripps · Pull Request #32454 · nodejs/node

AshCripps · 2020-03-24T10:26:05Z

Update the macos deployment target to 10.13 (High Sierra) for Node 14

refs: nodejs/build#2168

Checklist

documentation is changed or added

AshCripps · 2020-03-24T10:34:27Z

@nodejs/build

nodejs-github-bot · 2020-03-24T10:40:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30014/

AshCripps · 2020-03-24T11:12:46Z

@richardlau does this need the semver-major label?

mhdawson

LGTM

richardlau · 2020-03-24T15:09:26Z

@AshCripps can you also update https://github.com/nodejs/node/blob/master/BUILDING.md#official-binary-platforms-and-toolchains?

Update the macos deployment target to 10.13 (High Sierra) for Node 14 refs: nodejs/build#2168

AshCripps · 2020-03-24T15:24:44Z

@richardlau Done.

MylesBorins

LGTM

once nodejs/node#32454 lands it doesnt make sense to test master on 10.11 anymore with the deployment target set to 10.13

once nodejs/node#32454 lands it doesnt make sense to test master on 10.11 anymore with the deployment target set to 10.13 refs: nodejs/node#32454

nodejs-github-bot · 2020-03-25T16:10:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30052/

Update the macos deployment target to 10.13 (High Sierra) for Node 14 refs: nodejs/build#2168 PR-URL: #32454 Refs: nodejs/build#2168 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: James M Snell <jasnell@gmail.com>

richardlau · 2020-03-26T13:41:49Z

Landed in a621608.

once nodejs/node#32454 lands it doesnt make sense to test master on 10.11 anymore with the deployment target set to 10.13 refs: nodejs/node#32454

Notable changes: * (SEMVER-MAJOR) crypto: move pbkdf2 without digest to EOL (James M Snell) [#31166](#31166) * (SEMVER-MAJOR) fs: deprecate closing FileHandle on garbage collection (James M Snell) [#28396](#28396) * (SEMVER-MAJOR) http: move OutboundMessage.prototype.flush to EOL (James M Snell) [#31164](#31164) * (SEMVER-MAJOR) lib: move GLOBAL and root aliases to EOL (James M Snell) [#31167](#31167) * (SEMVER-MAJOR) os: move tmpDir() to EOL (James M Snell) [#31169](#31169) * (SEMVER-MAJOR) src: remove deprecated wasm type check (Clemens Backes) [#32116](#32116) * (SEMVER-MAJOR) stream: move \_writableState.buffer to EOL (James M Snell) [#31165](#31165) * (SEMVER-MINOR) doc: deprecate process.mainModule (Antoine du HAMEL) [#32232](#32232) * (SEMVER-MINOR) doc: deprecate process.umask() with no arguments (Colin Ihrig) [#32499](#32499) * (SEMVER-MAJOR) build: update macos deployment target to 10.13 for 14.x (AshCripps) [#32454](#32454) * (SEMVER-MAJOR) win: block running on EOL Windows versions (João Reis) [#31954](#31954) * (SEMVER-MAJOR) deps: update V8 to 8.1.307.20 (Matheus Marchini) [#32116](#32116) PR-URL: #32181

nodejs-github-bot added the build Issues and PRs related to Node.js builds or CI infrastructure. label Mar 24, 2020

richardlau mentioned this pull request Mar 24, 2020

Platform requirements for Node.js 14 nodejs/build#2168

Closed

7 of 8 tasks

richardlau approved these changes Mar 24, 2020

View reviewed changes

richardlau added the macos Issues and PRs related to the macOS platform. label Mar 24, 2020

richardlau added the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 24, 2020

BethGriggs approved these changes Mar 24, 2020

View reviewed changes

richardlau mentioned this pull request Mar 24, 2020

Node.js Build WorkGroup Meeting 2020-03-24 nodejs/build#2235

Closed

mhdawson approved these changes Mar 24, 2020

View reviewed changes

build: update macos deployment target to 10.13 for 14.x

edad53e

Update the macos deployment target to 10.13 (High Sierra) for Node 14 refs: nodejs/build#2168

AshCripps force-pushed the update-mac-deployment-target branch from d851ea1 to edad53e Compare March 24, 2020 15:24

richardlau approved these changes Mar 24, 2020

View reviewed changes

MylesBorins approved these changes Mar 24, 2020

View reviewed changes

richardlau mentioned this pull request Mar 24, 2020

thread-local storage unavailable on OSX10.10 #32467

Closed

rvagg approved these changes Mar 25, 2020

View reviewed changes

AshCripps pushed a commit to AshCripps/build that referenced this pull request Mar 25, 2020

ansible: stoping testing 14.x on OSX10.11

e778b2e

once nodejs/node#32454 lands it doesnt make sense to test master on 10.11 anymore with the deployment target set to 10.13

AshCripps mentioned this pull request Mar 25, 2020

jenkins: stop testing 14.x on OSX10.11 nodejs/build#2248

Merged

AshCripps pushed a commit to AshCripps/build that referenced this pull request Mar 25, 2020

ansible: stop testing 14.x on OSX10.11

05e949e

once nodejs/node#32454 lands it doesnt make sense to test master on 10.11 anymore with the deployment target set to 10.13 refs: nodejs/node#32454

AshCripps pushed a commit to AshCripps/build that referenced this pull request Mar 25, 2020

ansible: stop testing 14.x on OSX10.11

f1b43cf

once nodejs/node#32454 lands it doesnt make sense to test master on 10.11 anymore with the deployment target set to 10.13 refs: nodejs/node#32454

AshCripps pushed a commit to AshCripps/build that referenced this pull request Mar 25, 2020

jenkins: stop testing 14.x on OSX10.11

69a1a75

once nodejs/node#32454 lands it doesnt make sense to test master on 10.11 anymore with the deployment target set to 10.13 refs: nodejs/node#32454

jasnell approved these changes Mar 25, 2020

View reviewed changes

richardlau added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 25, 2020

richardlau closed this Mar 26, 2020

AshCripps pushed a commit to nodejs/build that referenced this pull request Mar 26, 2020

jenkins: stop testing 14.x on OSX10.11 (#2248)

93a4bff

once nodejs/node#32454 lands it doesnt make sense to test master on 10.11 anymore with the deployment target set to 10.13 refs: nodejs/node#32454

AshCripps deleted the update-mac-deployment-target branch March 26, 2020 14:47

BethGriggs mentioned this pull request Apr 7, 2020

2020-04-21, Version 14.0.0 (Current) #32181

Merged

Navigation Menu

Repository navigation

build: update macos deployment target to 10.13 for 14.x - #32454

build: update macos deployment target to 10.13 for 14.x#32454
AshCripps wants to merge 1 commit into
nodejs:masterfrom
AshCripps:update-mac-deployment-target

AshCripps commented Mar 24, 2020

Uh oh!

AshCripps commented Mar 24, 2020

Uh oh!

nodejs-github-bot commented Mar 24, 2020

Uh oh!

AshCripps commented Mar 24, 2020

Uh oh!

mhdawson left a comment

Uh oh!

richardlau commented Mar 24, 2020

Uh oh!

AshCripps commented Mar 24, 2020

Uh oh!

MylesBorins left a comment

Uh oh!

nodejs-github-bot commented Mar 25, 2020

Uh oh!

richardlau commented Mar 26, 2020

Uh oh!

Conversation

AshCripps commented Mar 24, 2020

Checklist

Uh oh!

AshCripps commented Mar 24, 2020

Uh oh!

nodejs-github-bot commented Mar 24, 2020

Uh oh!

AshCripps commented Mar 24, 2020

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

richardlau commented Mar 24, 2020

Uh oh!

AshCripps commented Mar 24, 2020

Uh oh!

MylesBorins left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Mar 25, 2020

Uh oh!

richardlau commented Mar 26, 2020

Uh oh!