Repository navigation
debugger: validate sec-websocket-accept response header - #39357
Merged
Merged
Conversation
Trott
force-pushed
the
validate-websocket
branch
from
July 11, 2021 22:08
5e5edc5 to
dfa5c74
Compare
This comment has been minimized.
This comment has been minimized.
Trott
force-pushed
the
validate-websocket
branch
from
July 11, 2021 23:14
dfa5c74 to
9fe423a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
cjihrig
approved these changes
Jul 13, 2021
cjihrig
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Is "WebSocket" the correct capitalization of the word? I could be wrong, but thought I'd ask since you're using "Websocket" throughout this PR.
Trott
force-pushed
the
validate-websocket
branch
from
July 13, 2021 03:55
9fe423a to
819846c
Compare
Member
Author
Fixed it in the commit messages and in the code added here. |
First commit by @copperwall:
Second commit:
Refs: nodejs/node-inspect#93