Skip to content

deps: cherry-pick 1f53e42 from v8 upstream - #7612

Merged
bnoordhuis merged 1 commit into
nodejs:masterfrom
bnoordhuis:fix7536
Jul 18, 2016
Merged

deps: cherry-pick 1f53e42 from v8 upstream#7612
bnoordhuis merged 1 commit into
nodejs:masterfrom
bnoordhuis:fix7536

Conversation

@bnoordhuis

@bnoordhuis bnoordhuis commented Jul 8, 2016 •
edited
Loading

Copy link
Copy Markdown
Member

Original commit message:

Handle symbols in FrameMirror#invocationText().

Fix a TypeError when putting together the invocationText for a
symbol method's stack frame.

See #7536.

Review-Url: https://codereview.chromium.org/2122793003
Cr-Commit-Position: refs/heads/master@{#37597}

Fixes: #7536

R=@nodejs/v8

Word from upstream is that 5.1 is abandoned so I haven't requested a back-port. (Well, I did, but it's unlikely to happen. I did request back-ports to 5.2 and 5.3.)

CI: https://ci.nodejs.org/job/node-test-pull-request/3218/
CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/183/

@bnoordhuis bnoordhuis added debugger v8 engine Issues and PRs related to the V8 dependency. labels Jul 8, 2016
@targos

targos commented Jul 8, 2016

Copy link
Copy Markdown
Member

LGTM

@bnoordhuis

bnoordhuis commented Jul 8, 2016

Copy link
Copy Markdown
Member Author

java.io.IOException on pi3-raspbian-jessie but otherwise green. V8 test suite is green.

@cjihrig

cjihrig commented Jul 8, 2016

Copy link
Copy Markdown
Contributor

LGTM

@bnoordhuis
deps: cherry-pick 1f53e42 from v8 upstream
f427d27 
Original commit message:

    Handle symbols in FrameMirror#invocationText().

    Fix a TypeError when putting together the invocationText for a
    symbol method's stack frame.

    See nodejs#7536.

    Review-Url: https://codereview.chromium.org/2122793003
    Cr-Commit-Position: refs/heads/master@{nodejs#37597}

Fixes: nodejs#7536
@bnoordhuis bnoordhuis closed this Jul 18, 2016
@bnoordhuis
bnoordhuis deleted the fix7536 branch July 18, 2016 09:00
@bnoordhuis
bnoordhuis merged commit f427d27 into nodejs:master Jul 18, 2016
@bnoordhuis

bnoordhuis commented Jul 18, 2016 •
edited
Loading

Copy link
Copy Markdown
Member Author

Apologies, something went wrong while pushing to master. Landed in 5cdbbdf, thanks for the reviews.

bnoordhuis added a commit that referenced this pull request Jul 18, 2016
@bnoordhuis
deps: cherry-pick 1f53e42 from v8 upstream