You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Question] Why there is that gradient background at the bottom of the sidebar? #513
@dkfiresky nodejs/node#4748 describes your problem and a fix for it. If I use Safari with El Cap and the latest docs I can't see a gradient.
The commit landed in the 4.x staging, but I believe there was no release between the landing of the commit and now.
/cc @silverwind
The bugged gradient on Safari was fixed in nodejs/node#4748 and the fix has been released with the 5.6.0 docs a few hours ago, so you should see it working as intended now:
The purpose is simply to indicate the scrollability of the sidebar, which might not be obvious because scrollbars are hidden.
@stevemao that's because the backport of nodejs/node#4748 hasn't been released yet. It's a bit unfortunate, but we have to wait for the next LTS release for the 4.x docs.
@dkfiresky that behaviour is very browser-specific (Chromes does bubble the scroll event when the limit is reached, Firefox does not) from what I've tested, but I assume improvements can be made to have make it behave more like http://devdocs.io/node/ for example.
I really think doc/api_assets should be managed here in this repo. I know this was brought a long time ago and requires build scripts changes so yeah :)
Yeah that'd be my preference as well for faster propagation of stuff like this. On the other hand, it's kind of nice that each API release has its own standalone package of docs.
Activity
leo commentedon Feb 9, 2016
I don't like it either, but it probably indicates that there are other API categories below the visible ones.
r-52 commentedon Feb 9, 2016
@dkfiresky nodejs/node#4748 describes your problem and a fix for it. If I use Safari with El Cap and the latest docs I can't see a gradient.
The commit landed in the 4.x staging, but I believe there was no release between the landing of the commit and now.
/cc @silverwind
silverwind commentedon Feb 9, 2016
The bugged gradient on Safari was fixed in nodejs/node#4748 and the fix has been released with the 5.6.0 docs a few hours ago, so you should see it working as intended now:
The purpose is simply to indicate the scrollability of the sidebar, which might not be obvious because scrollbars are hidden.
silverwind commentedon Feb 9, 2016
I wasn't seeing this, could you check if it's still an issue right now?
stevemao commentedon Feb 9, 2016
@silverwind I confirm it is on https://nodejs.org/dist/latest-v4.x/docs/api/
But not on https://nodejs.org/dist/latest-v5.x/docs/api/ anymore.
I'm on Windows 7 Chrome, oh it is on bottom not top.
stevemao commentedon Feb 9, 2016
silverwind commentedon Feb 10, 2016
@stevemao that's because the backport of nodejs/node#4748 hasn't been released yet. It's a bit unfortunate, but we have to wait for the next LTS release for the 4.x docs.
silverwind commentedon Feb 10, 2016
I was going for a more "modern" style, and I think it looks cleaner without a scrollbar.
The rendering in your original screenshot was a bug. Chrome, Firefox and IE didn't show it, and I learned my lesson for not testing Safari :)
silverwind commentedon Feb 10, 2016
@dkfiresky that behaviour is very browser-specific (Chromes does bubble the scroll event when the limit is reached, Firefox does not) from what I've tested, but I assume improvements can be made to have make it behave more like http://devdocs.io/node/ for example.
silverwind commentedon Feb 11, 2016
I'm working on the scrolling issues and other misc things on the API docs's CSS.
silverwind commentedon Feb 11, 2016
@dkfiresky yes, I already figured out how they do it, took me some time though 😉
See nodejs/node#5198 for my propsed changes.
stevemao commentedon Feb 12, 2016
I really think
doc/api_assetsshould be managed here in this repo. I know this was brought a long time ago and requires build scripts changes so yeah :)silverwind commentedon Feb 12, 2016
Yeah that'd be my preference as well for faster propagation of stuff like this. On the other hand, it's kind of nice that each API release has its own standalone package of docs.