Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
ronag
approved these changes
Oct 1, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5942 +/- ##
==========================================
- Coverage 94.04% 86.10% -7.95%
==========================================
Files 110 115 +5
Lines 40252 45620 +5368
==========================================
+ Hits 37856 39282 +1426
- Misses 2396 6338 +3942 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
CI note: the four failing Node.js 22 jobs all abort in the unrelated |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Hardening
interceptors.responseError()against retaining arbitrarily large decoded error bodies.Rationale
responseErrorautomatically decodes JSON and plain-text error responses so they can be attached toResponseError.body. Those bodies previously had no interceptor-specific retention limit.Changes
Features
maxSizeoption tointerceptors.responseError().maxSize: 0restores unlimited retention.ResponseError.bodyTruncatedso callers can detect a retained prefix.Bug Fixes
responseErroris composed after decompression.Breaking Changes and Deprecations
Error bodies larger than 1 MiB are truncated by default. Applications that intentionally consume larger error bodies can configure a larger
maxSizeor set it to0to retain the previous unlimited behavior.Status
Validation
npm run test:unit— 1,568 passed, 5 skippednpx borp -p "test/interceptors/response-error.js"— 14 passednpm run test:typescriptnpm run lintgit diff --check