Skip to content

Add shutdown method to samplers #5713

Description

@tammy-baylis-swi

Is your feature request related to a problem?

The sampler doesn't have a shutdown method. This is a problem for any samplers that manage resources like thread pools / connections; they need to be shutdown to prevent memory leaks. A community sampler that has this issue is AwsXRayRemoteSampler.

Describe the solution you'd like

Let's add a shutdown method to the OTel Python Sampler ABC that gets called when TracerProvider is shutdown. Then, implement for AwsXRayRemoteSampler. See also:

Describe alternatives you've considered

No response

Additional Context

No response

Would you like to implement a fix?

None

Tip

React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it. Learn more here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions