Skip to content

"Re-running failed tests in verbose mode" does not use host runner #94052

Open
Open
"Re-running failed tests in verbose mode" does not use host runner#94052
Labels
3.11only security fixes3.12only security fixestestsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

Description

@tiran
tiran
opened on Jun 21, 2022

Bug report

Issue GH-84461 / PR GH-91930 introduces a new test runner API to execute tests with a different Python interpreter. It is used by WebAssembly and other cross-compile targets to run tests. The test controll process uses the native build Python interpreter while the tests workers use the cross compiled host Python interpreter with a HOSTRUNNER like wasmtime or NodeJS.

The rerun_failed_tests() method does not use ns.python. Failed tests are re-executed with the build Python instead of host Python.

@ethanhs

Activity

  1. tiran
    added
    type-bugAn unexpected behavior, bug, or error
    testsTests in the Lib/test dir
    3.11only security fixes
    3.12only security fixes
    on Jun 21, 2022
  2. miss-islington
    added 2 commits that reference this issue on Jun 21, 2022

    pythongh-94052: Don't re-run failed tests with --python option (pytho…

    e0e54e8

    gh-94052: Don't re-run failed tests with --python option (GH-94054)

    1347607

  3. emmatyping commented on Jun 22, 2022

    @emmatyping
    emmatyping
    on Jun 22, 2022
    Member

    It seems that rerunning failed tests does not use processes at all unfortunately :/

    I think the test rerunning code could be modified to use the multiprocess test executor with some effort.

  4. serhiy-storchaka
    added a commit that references this issue on Jun 26, 2022

    Revert 30935 defer bpo45162 to 312 (#94285)

    1ffde3e
  5. vstinner
    added 3 commits that reference this issue on Sep 2, 2023

    Revert "pythongh-94052: Don't re-run failed tests with --python option (

    b95c315

    pythongh-94052: Don't re-run failed tests with --python option (pytho…

    70d8b30

    [3.11] gh-108822: Backport libregrtest changes from the main branch (#…

    79f7a4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.11only security fixes3.12only security fixestestsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions