Skip to content

Add mmap as a valid buffer type. - #2895

Merged
srittau merged 1 commit into
python:masterfrom
alexchamberlain:mmap
Mar 30, 2019
Merged

Add mmap as a valid buffer type.#2895
srittau merged 1 commit into
python:masterfrom
alexchamberlain:mmap

Conversation

@alexchamberlain

@alexchamberlain alexchamberlain commented Mar 30, 2019

Copy link
Copy Markdown
Contributor

Currently seeing the following error from mypy, which I think this should solve:

foo.py:47: error: Argument 1 to "pack_into" of "Struct" has incompatible type "mmap"; expected "Union[array[Any], bytearray, memoryview]"

srittau
srittau approved these changes Mar 30, 2019
View reviewed changes

@srittau srittau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This also relates to python/typing#593

@srittau
srittau merged commit f11d061 into python:master Mar 30, 2019
@srittau srittau mentioned this pull request Mar 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittau srittau srittau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexchamberlain @srittau