Repository navigation
Conversation
Summary: All headers in `react/renderer/animated` were classified as "for frameworks". Most of them are implementation details of the C++ Native Animated engine: the concrete animation drivers, the concrete animated node types, and the `internal/` helpers. They are not part of the integration surface hosts use, and none of the remaining "for frameworks" headers includes them (the manager headers only forward-declare `AnimatedNode`, `AnimationDriver` and `AnimatedMountingOverrideDelegate`). This moves those 23 headers to the private tier: - `drivers/`: `AnimationDriver.h`, `AnimationDriverUtils.h`, `DecayAnimationDriver.h`, `FrameAnimationDriver.h`, `SpringAnimationDriver.h` - `internal/`: `AnimatedMountingOverrideDelegate.h`, `NativeAnimatedAllowlist.h`, `primitives.h` - `nodes/`: all concrete node types except the `AnimatedNode` base class Changelog: [Internal] Differential Revision: D123404796
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123404796. |
cortinico
approved these changes
Oct 7, 2026
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
All headers in
react/renderer/animatedwere classified as "for frameworks". Most of them are implementation details of the C++ Native Animated engine: the concrete animation drivers, the concrete animated node types, and theinternal/helpers. They are not part of the integration surface hosts use, and none of the remaining "for frameworks" headers includes them (the manager headers only forward-declareAnimatedNode,AnimationDriverandAnimatedMountingOverrideDelegate).This moves those 23 headers to the private tier:
drivers/:AnimationDriver.h,AnimationDriverUtils.h,DecayAnimationDriver.h,FrameAnimationDriver.h,SpringAnimationDriver.hinternal/:AnimatedMountingOverrideDelegate.h,NativeAnimatedAllowlist.h,primitives.hnodes/: all concrete node types except theAnimatedNodebase classChangelog: [Internal]
Differential Revision: D123404796