Repository navigation
Make core Dynamic* and ReactRootViewTagGenerator headers for-frameworks (#58884) - #58884
Open
j-piasecki wants to merge 1 commit into
Open
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123610705. |
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 6, 2026
…ks (react#58884) Summary: `DynamicEventPayload.h`, `DynamicPointerEvent.h`, `DynamicPropsUtilities.h` and `ReactRootViewTagGenerator.h` are used by React Native's own sources and by platform and host integrations, not by component code, so they move from the public to the "for frameworks" tier of the C++ stable API and leave the `<React/RendererCore.h>` umbrella. Consumers that opt into `RN_STRICT_API` get a warning if they include these headers directly, which they can acknowledge with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert. Changelog: [Internal] Differential Revision: D123610705
j-piasecki
force-pushed
the
export-D123610705
branch
from
October 6, 2026 12:43
44e23ac to
9747f39
Compare
…ks (react#58884) Summary: Pull Request resolved: react#58884 `DynamicEventPayload.h`, `DynamicPointerEvent.h`, `DynamicPropsUtilities.h` and `ReactRootViewTagGenerator.h` are used by React Native's own sources and by platform and host integrations, not by component code, so they move from the public to the "for frameworks" tier of the C++ stable API and leave the `<React/RendererCore.h>` umbrella. Consumers that opt into `RN_STRICT_API` get a warning if they include these headers directly, which they can acknowledge with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert. Changelog: [Internal] Differential Revision: D123610705
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 6, 2026
…ks (react#58884) Summary: Pull Request resolved: react#58884 `DynamicEventPayload.h`, `DynamicPointerEvent.h`, `DynamicPropsUtilities.h` and `ReactRootViewTagGenerator.h` are used by React Native's own sources and by platform and host integrations, not by component code, so they move from the public to the "for frameworks" tier of the C++ stable API and leave the `<React/RendererCore.h>` umbrella. Consumers that opt into `RN_STRICT_API` get a warning if they include these headers directly, which they can acknowledge with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert. Changelog: [Internal] Differential Revision: D123610705
j-piasecki
force-pushed
the
export-D123610705
branch
from
October 6, 2026 12:48
9747f39 to
4973560
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
DynamicEventPayload.h,DynamicPointerEvent.h,DynamicPropsUtilities.handReactRootViewTagGenerator.hare used by React Native's own sources and by platform and host integrations, not by component code, so they move from the public to the "for frameworks" tier of the C++ stable API and leave the<React/RendererCore.h>umbrella. Consumers that opt intoRN_STRICT_APIget a warning if they include these headers directly, which they can acknowledge withRN_ALLOW_FRAMEWORKS; without that flag the guards are inert.Changelog: [Internal]
Differential Revision: D123610705