Repository navigation
RNTester: compile RCTUtilsTests in the RNTesterUnitTests target - #58894
Open
YevheniiKotyrlo wants to merge 1 commit into
Open
YevheniiKotyrlo wants to merge 1 commit into
YevheniiKotyrlo wants to merge 1 commit into
Conversation
RNTesterPods.xcodeproj never listed RNTesterUnitTests/RCTUtilsTests.m, so its two tests were neither compiled nor run.
|
@javache has imported this pull request. If you are a Meta employee, you can view this in D123784162. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
packages/rn-tester/RNTesterUnitTests/RCTUtilsTests.misn't inRNTesterPods.xcodeproj. It's the one test file inRNTesterUnitTests/with no file reference and no Sources entry, soyarn test-iosnever compiles it andtestRCTHumanReadableTypeandtestRCTValidateTypeOfViewCommandArgumentnever run. This adds the file to theRNTesterUnitTeststarget.Changelog:
[INTERNAL] [FIXED] - Compile RCTUtilsTests in the RNTesterUnitTests target
Test Plan:
xcodebuild test -workspace RNTesterPods.xcworkspace -scheme RNTester -sdk iphonesimulator -destination 'platform=iOS Simulator,id=<udid>' -only-testing:RNTesterUnitTests/RCTUtilsTests: onmainit executes no tests; with this change it executes 2, and both pass. Changing the expected value of the first assertion makes the run fail.RNTesterscheme, with Metro and the WebSocket test server up asscripts/objc-test.sh teststarts them:RNTesterUnitTests170 tests, 16 skipped, 0 failures, with bothRCTUtilsTestscases among them. I ran it on the iOS 18.0 runtime;scripts/.tests.envasks for 18.3.1, which this machine doesn't have.