Repository navigation
PR merge rule and PR template suggestion #23
Description
pr merge
Since no PR has been merged yet, I think it would be good to make rule for merging PR.
pr template
<!--
Thank you for the PR! Contributors like you keep React awesome!
Please see the Contribution Guide for guidelines:
https://github.com/reactjs/reactjs.org/blob/master/CONTRIBUTING.md
If your PR references an existing issue, please add the issue number below
-->
here is the current PR template, but if the checklist is included here, contributors and reviewers can check the progress of the PR so it can bring better communicate better.
Activity
gnujoow commentedon Feb 12, 2019
for PR mege I suggest PR is merged if it has (at least) two approve from reviewer or maintainer to check the quality of the translation.
gnujoow commentedon Feb 12, 2019
if this checklist included in template, I think this will be able to help contributors to check their tranlation progress.
taehwanno commentedon Feb 12, 2019
I agree :)
Good idea. We need to add
UNIVERSAL-STYLE-GUIDE.mdin #17.hg-pyun commentedon Feb 13, 2019
Yeah, It is a very coool idea.
taggon commentedon Feb 13, 2019
I think the third item should be "맞춤법 검사" rather than "띄어쓰기 검사", as the online tool checks more than spacing.
cadenzah commentedon Feb 13, 2019
The idea of
progress itemsis pretty nice. It will be easier to check important stuffs.taehwanno commentedon Feb 13, 2019
I applied "Require pull request reviews before merging" with options in the screenshot.
simsim0709 commentedon Feb 13, 2019
I agree 👍
gnujoow commentedon Feb 15, 2019
I will close this issue and make PR for PR templete this sunday. if there is any feed back on the checklist, comment on this thread by this week.
taggon commentedon Feb 17, 2019
The current PR template, which introduced by #25, contains broken links. If we don't have appropriate references for the items yet, it would be better to remove the links.
gnujoow commentedon Feb 21, 2019
@taggon I've just made pr to resolve the issue you mention.
#45