Conversation
siegfriedweber
added this pull request to stack #837
September 29, 2026 07:11
siegfriedweber
requested changes
Oct 5, 2026
siegfriedweber
left a comment
Member
There was a problem hiding this comment.
An entry in the changelog would be nice.
| }; | ||
|
|
||
| use super::{ | ||
| Error, ServiceSnafu, container::ContainerConfig, properties::product_logging, resource, |
Member
There was a problem hiding this comment.
Why does this module import Error instead of defining its own enum?
Member
Author
There was a problem hiding this comment.
I think that happened when the role group builder was moved and the errors were left where they were. In 61f3f5b I've moved them to role_group and added a helper so the builder loops are a little simpler.
adwk67
marked this pull request as ready for review
October 5, 2026 15:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Builds on #830
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker