Fix openzeppelin and soroban-examples tests for v28 - #2761
Merged
Merged
Conversation
leighmcculloch
marked this pull request as ready for review
September 28, 2026 03:09
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Updates Soroban Examples and OpenZeppelin Contracts test workflows for soroban-sdk v28 by removing the obsolete spec-shaking feature matrix.
Changes:
- Removes obsolete feature-injection steps and matrix legs.
- Simplifies artifact naming.
| File | Description |
|---|---|
.github/workflows/test-with-soroban-examples.yml |
Removes obsolete feature matrix and setup. |
.github/workflows/test-with-openzeppelin-contracts.yml |
Removes obsolete feature matrix and setup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
leighmcculloch
added a commit
that referenced
this pull request
Sep 28, 2026
fnando
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the
experimental_spec_shaking_v2matrix leg from the soroban-examples and OpenZeppelin contracts test workflows.Why
soroban-sdk v28 removed the
experimental_spec_shaking_v2feature because spec shaking is now always on, so injecting it fails dependency resolution and turns both workflows red now that the upstream repos depend on soroban-sdk 28.Known limitations
N/A