Repository navigation
fix(change): reject non-canonical git change URIs - #797
Merged
behinddwalls merged 2 commits intoOct 7, 2026
Merged
behinddwalls merged 2 commits into
behinddwalls merged 2 commits into
Conversation
DivyanshGarg380
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 7, 2026 09:30
Collaborator
|
i think this is already done? can you rebase and check again |
DivyanshGarg380
force-pushed
the
DivyanshGarg380/git-changeid-canonical
branch
from
October 7, 2026 17:36
bf9ee05 to
be31d5c
Compare
Contributor
Author
|
Hey, rebased the branch and pushed the updated changes. I also checked that the canonicalization fix is still not present in main |
behinddwalls
approved these changes
Oct 7, 2026
behinddwalls
enabled auto-merge
October 7, 2026 21:08
behinddwalls
temporarily deployed
to
stack-rebase
October 7, 2026 21:24 — with 
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
ParseChangeIDcurrently accepts Git change IDs that aren't in canonical form.net/urlnormalizes or drops parts of the URI, so different strings can end up representing the sameChangeID. The parser also accepts empty segments in the repository path.What?
Reject change IDs when:
ChangeIDdoesn't round-trip to the original inputAdded tests for uppercase schemes, userinfo, query parameters, fragments, non-canonical percent-encoding, and empty repository segments.
Test Plan
go test ./platform/base/change/git/...python .\tool\bazel --output_user_root=C:\bazel test //platform/base/change/git:allgit diff --checkIssue
Closes #796