Skip to content

fix: Side panel followup - #10678

Merged
snowystinger merged 4 commits into
mainfrom
SidePanel-followup
Sep 30, 2026
Merged

snowystinger merged 4 commits into
mainfrom
SidePanel-followup

Conversation

@snowystinger

@snowystinger snowystinger commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

Closes

Fixes issues from testing

  • The avatar shifts upwards slightly when you expand the side panel
  • focusring is clipped on the left
  • The alignment of the items in the account menu seem off.
  • Removed extraneous react component pointed out in previous review, thanks @LFDanLu
  • Added more elements to be able to test scrolling SideNav in a SidePanel in docs with the AccountFooter, fixed scrolling as a result
  • Add story with a nav element around SideNav

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices
  • I understand every change in this PR and can explain why it's there.
  • If AI-assisted, I followed our AI contribution guidance and pointed my assistant at AGENTS.md.

📝 Test Instructions:

🧢 Your Project:

@github-actions github-actions Bot added the S2 label Sep 29, 2026
@snowystinger snowystinger changed the title Side panel followup fix: Side panel followup Sep 29, 2026
@rspbot

rspbot commented Sep 29, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Sep 29, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Sep 29, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Sep 29, 2026

Copy link
Copy Markdown

Agent Skills Changes

Modified (10)
Install

React Spectrum S2:

npx skills add https://d1pzu54gtk2aed.cloudfront.net/pr/7c06a74e94914ff5a707926cb3f649b8e6f1b518/

React Aria:

npx skills add https://d5iwopk28bdhl.cloudfront.net/pr/7c06a74e94914ff5a707926cb3f649b8e6f1b518/

@LFDanLu LFDanLu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one small thing I noticed, but otherwise looks good

{id: 5, title: 'Photos', type: 'directory', href: '/photos', icon: Images, children: [
{id: 6, title: 'Image 1', type: 'file', href: '/image-1'},
{id: 7, title: 'Image 2', type: 'file', href: '/image-2'}
]},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed that expanding/collapsing folders in https://d1pzu54gtk2aed.cloudfront.net/pr/7c06a74e94914ff5a707926cb3f649b8e6f1b518/SidePanel#animations to make the sidepanel scrollable causes the items to briefly appear behind the user profile

Screen.Recording.2026-09-29.at.11.42.57.AM.mov

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, i noticed that yesterday as well, I think we're ok for alpha, but I'm working on figuring it out

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, approved

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working on it here #10684

@snowystinger
snowystinger added this pull request to the merge queue Sep 30, 2026
Merged via the queue into main with commit ffeacba Sep 30, 2026
31 checks passed
@snowystinger
snowystinger deleted the SidePanel-followup branch September 30, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants