fix: view transition animations - #10684
Draft
snowystinger wants to merge 7 commits into
Draft
snowystinger wants to merge 7 commits into
snowystinger wants to merge 7 commits into
Conversation
|
Build successful! 🎉 |
|
Build successful! 🎉 |
## API Changes
@react-aria/utils/@react-aria/utils:runAfterTransition runAfterTransition {
- fn: QueuedCallback
+ fn: () => void
returnVal: undefined
}/@react-aria/utils:isCtrlKeyPressed isCtrlKeyPressed {
- event: KeyPressEvent
+ e: Event
returnVal: undefined
}/@react-aria/utils:isKeyboardOpen-isKeyboardOpen {
- returnVal: undefined
-}/@react-aria/utils:supportsKeyboard-supportsKeyboard {
- returnVal: undefined
-}/@react-aria/utils:willOpenKeyboard willOpenKeyboard {
- target: Element | null
+ target: Element
returnVal: undefined
}@react-spectrum/ai/@react-spectrum/ai:PromptField PromptField {
acceptedAttachmentTypes?: Array<string>
aiDisclaimer?: React.ReactNode
attachments?: Array<PromptFieldAttachment>
brandColor?: string
children: React.ReactNode
defaultAttachments?: Array<PromptFieldAttachment>
defaultValue?: PromptFieldValue
isGenerating?: boolean
+ isReadOnlyWhileGenerating?: boolean = false
onAITermsPress?: () => void
onAddAttachments?: (Array<PromptFieldAttachment>) => void
onAttachmentsChange?: (Array<PromptFieldAttachment>) => void
onChange?: (PromptFieldValue) => void
onStop?: () => void
onSubmit?: (PromptFieldValue, Array<PromptFieldAttachment>) => void
size?: 'S' | 'M' = 'M'
styles?: StyleString
value?: PromptFieldValue
variant?: 'balanced' | 'prominent' | 'subtle' = 'balanced'
}/@react-spectrum/ai:PromptTokenField PromptTokenField {
children?: (TokenSegment<PromptFieldTokenValue>) => React.ReactElement
completionTrigger?: RegExp
menuWidth?: number
onKeyDown?: (React.KeyboardEvent<HTMLDivElement>) => void
- onKeyUp?: (React.KeyboardEvent<HTMLDivElement>) => void
pixelLoader?: Array<Cell> | Array<Array<Cell>>
placeholder?: string
renderCompletions?: (string, string | null) => Array<React.ReactNode> | null | Promise<Array<React.ReactNode> | null>
shouldAnimatePixelLoader?: boolean/@react-spectrum/ai:PromptFieldProps PromptFieldProps {
acceptedAttachmentTypes?: Array<string>
aiDisclaimer?: React.ReactNode
attachments?: Array<PromptFieldAttachment>
brandColor?: string
children: React.ReactNode
defaultAttachments?: Array<PromptFieldAttachment>
defaultValue?: PromptFieldValue
isGenerating?: boolean
+ isReadOnlyWhileGenerating?: boolean = false
onAITermsPress?: () => void
onAddAttachments?: (Array<PromptFieldAttachment>) => void
onAttachmentsChange?: (Array<PromptFieldAttachment>) => void
onChange?: (PromptFieldValue) => void
onStop?: () => void
onSubmit?: (PromptFieldValue, Array<PromptFieldAttachment>) => void
size?: 'S' | 'M' = 'M'
styles?: StyleString
value?: PromptFieldValue
variant?: 'balanced' | 'prominent' | 'subtle' = 'balanced'
}/@react-spectrum/ai:PromptTokenFieldProps PromptTokenFieldProps {
children?: (TokenSegment<PromptFieldTokenValue>) => React.ReactElement
completionTrigger?: RegExp
menuWidth?: number
onKeyDown?: (React.KeyboardEvent<HTMLDivElement>) => void
- onKeyUp?: (React.KeyboardEvent<HTMLDivElement>) => void
pixelLoader?: Array<Cell> | Array<Array<Cell>>
placeholder?: string
renderCompletions?: (string, string | null) => Array<React.ReactNode> | null | Promise<Array<React.ReactNode> | null>
shouldAnimatePixelLoader?: boolean@react-spectrum/s2/@react-spectrum/s2:SidePanel SidePanel {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
children?: ReactNode
defaultCollapsed?: boolean
isCollapsed?: boolean
onCollapsedChange?: (boolean) => void
styles?: StylesPropWithHeight
+ width?: number = 208
}/@react-spectrum/s2:SidePanelProps SidePanelProps {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
children?: ReactNode
defaultCollapsed?: boolean
isCollapsed?: boolean
onCollapsedChange?: (boolean) => void
styles?: StylesPropWithHeight
+ width?: number = 208
} |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
Set the AI to solving my animation woes. I'm working on reviewing and simplifying now. The general idea was, use animating clip paths for each item during the animation so that they don't appear outside the bounds of the SidePanel or the SideNav while animations are happening.
For testing, you can use Chrome's dev tool animation tab. If you put in on 10% animation, you can easily see if/when any elements overlap. The items should not appear over the content region nor over the account footer in the Animations example in the s2 docs.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: