Repository navigation
Reach public ReactCommon modules through umbrellas from Android platform headers - #58886
Open
j-piasecki wants to merge 3 commits into
Open
j-piasecki wants to merge 3 commits into
j-piasecki wants to merge 3 commits into
Conversation
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123610673. |
…ks (react#58884) Summary: Pull Request resolved: react#58884 `DynamicEventPayload.h`, `DynamicPointerEvent.h`, `DynamicPropsUtilities.h` and `ReactRootViewTagGenerator.h` are used by React Native's own sources and by platform and host integrations, not by component code, so they move from the public to the "for frameworks" tier of the C++ stable API and leave the `<React/RendererCore.h>` umbrella. Consumers that opt into `RN_STRICT_API` get a warning if they include these headers directly, which they can acknowledge with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert. Changelog: [Internal] Differential Revision: D123610705
…headers Summary: Exported iOS headers in `React/Fabric` (`RCTViewComponentView.h`, `RCTComponentViewProtocol.h`, `RCTTouchableComponentViewProtocol.h`, `RCTComponentViewFactory.h`, `RCTComponentViewRegistry.h`, `RCTConversions.h`, `RCTMountingManager.h`, `RCTScheduler.h`, `RCTSurfacePresenter.h`, `RCTSurfacePresenterBridgeAdapter.h`, `AppleEventBeat.h`, `Utils/PlatformRunLoopObserver.h`, `Utils/RCTLinearGradient.h`, `Utils/RCTRadialGradient.h`) and `RCTHost.h` included fine-grained headers of public ReactCommon modules. Under `RN_STRICT_API` those hit the modules' public guard in any app or library that imports them — `RCTViewComponentView.h` is the base class of most third-party Fabric components — so they now include the module umbrellas (`<React/RendererCore.h>`, `<React/View.h>`, `<React/Graphics.h>`, `<React/ComponentRegistry.h>`, `<React/Utils.h>`, `<React/Timing.h>`) instead. Includes of "for frameworks" headers are unchanged. The guards are inert without that flag. Changelog: [Internal] Differential Revision: D123610706
j-piasecki
force-pushed
the
export-D123610673
branch
from
October 6, 2026 12:43
ed66ca4 to
2d5bf15
Compare
…orm headers Summary: Android headers exported through prefab (`react/fabric/AndroidEventBeat.h`, `EventEmitterWrapper.h`, `FabricMountingManager.h`, `StateWrapperImpl.h`, `ComponentFactory.h`, `CoreComponentsRegistry.h`, `react/common/mapbuffer/JReadableMapBuffer.h`, and `DefaultComponentsRegistry.h`, which app `OnLoad.cpp` files include) included fine-grained headers of public ReactCommon modules. Under `RN_STRICT_API` those hit the modules' public guard in any app or library that includes them, so they now include `<React/RendererCore.h>`, `<React/ComponentRegistry.h>`, `<React/Debug.h>` and `<React/MapBuffer.h>` instead. Includes of "for frameworks" headers are unchanged. The guards are inert without that flag. Changelog: [Internal] Differential Revision: D123610673
j-piasecki
force-pushed
the
export-D123610673
branch
from
October 6, 2026 12:47
2d5bf15 to
438d33d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Android headers exported through prefab (
react/fabric/AndroidEventBeat.h,EventEmitterWrapper.h,FabricMountingManager.h,StateWrapperImpl.h,ComponentFactory.h,CoreComponentsRegistry.h,react/common/mapbuffer/JReadableMapBuffer.h, andDefaultComponentsRegistry.h, which appOnLoad.cppfiles include) included fine-grained headers of public ReactCommon modules. UnderRN_STRICT_APIthose hit the modules' public guard in any app or library that includes them, so they now include<React/RendererCore.h>,<React/ComponentRegistry.h>,<React/Debug.h>and<React/MapBuffer.h>instead. Includes of "for frameworks" headers are unchanged. The guards are inert without that flag.Changelog: [Internal]
Differential Revision: D123610673