Repository navigation
ADR: CA bundle injection for webhooks - #522
Merged
Merged
Conversation
✅ Deploy Preview for stackable-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adwk67
reviewed
Jan 9, 2024
Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.de>
Techassi
reviewed
Jan 9, 2024
Co-authored-by: Techassi <git@techassi.dev>
adwk67
reviewed
Jan 15, 2024
…ndle.adoc Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.de>
maltesander
marked this pull request as ready for review
January 22, 2024 13:16
adwk67
previously approved these changes
Jan 22, 2024
adwk67
left a comment
Member
There was a problem hiding this comment.
lgtm! Just a few minor suggestions.
Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.de>
…ndle.adoc Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.de>
…ion' into adr-foundation-webhoos-ca-injection
razvan
reviewed
Jan 29, 2024
razvan
reviewed
Jan 29, 2024
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
Member
|
More on OLM : according to the documentation, OLM does it's own CA injection:
How will this affect our approach ? |
Member
To answer my own question, after spiking a dummy webhook with the secret op on OLM: we should not do CA bundle injection on OLM. Also I think as part of the foundation work, this ADR should describe what kind of configuation triggers the secret op to do CA injection. |
sbernauer
reviewed
Feb 9, 2024
Techassi
approved these changes
Mar 5, 2024
Techassi
left a comment
Member
There was a problem hiding this comment.
This is in a mergeable state. Fine adjustments (like adding further details) can be added at a later point in time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refinement 05.02.2024
ecformat.preview link: https://deploy-preview-522--stackable-docs.netlify.app/home/nightly/contributor/adr/adr033-foundation-webhooks-ca-bundle