Repository navigation
feat: Add TLS certificate util crate - #736
Merged
Merged
Conversation
This was referenced Feb 13, 2024
Member
Author
|
The basic work is mostly done, but a few pieces are still missing:
|
Member
Author
I decided to move this into a separate PR as this PR is already big enough. Both features can be implemented on top of the changes introduced in this PR. |
This code will be re-introduced in a follow-up PR.
Techassi
marked this pull request as ready for review
March 4, 2024 13:35
nightkr
reviewed
Mar 12, 2024
Co-authored-by: Natalie Klestrup Röijezon <teo@nullable.se>
This reverts commit a0182d7.
nightkr
reviewed
Mar 13, 2024
NickLarsenNZ
previously approved these changes
Mar 15, 2024
NickLarsenNZ
left a comment
Member
There was a problem hiding this comment.
Left some comments. None of them should be blockers. Will let you decide whether to include them.
Techassi
enabled auto-merge
March 15, 2024 10:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #730, discussed in stackabletech/documentation#522, tracked by stackabletech/issues#361
This PR adds a crate which handles TLS certificate generation, reading and writing.