Repository navigation
feat: Add support for webhook servers - #730
Merged
Merged
Conversation
Techassi
marked this pull request as ready for review
February 12, 2024 14:57
Member
Author
|
I just realized this still needs version bumps for |
These tests required a lot of manual setup, which is not desirable. In the future, we need to enable automatic testing of these servers.
These new versions introduced quite a few breaking changes which required a slight reworkf of the TLS cert handling code.
Member
Author
|
The crates are now all up-to-date. This PR is now reviewable. |
This was referenced Feb 13, 2024
NickLarsenNZ
requested changes
Feb 13, 2024
NickLarsenNZ
left a comment
Member
There was a problem hiding this comment.
I generally approve, but left enough comments that I assume changes will be made.
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
NickLarsenNZ
previously approved these changes
Feb 14, 2024
NickLarsenNZ
self-requested a review
February 14, 2024 12:21
Techassi
added a commit
that referenced
this pull request
Feb 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes stackabletech/issues#508, supersedes #695, part of stackabletech/issues#361
This adds support to create webhook servers based on
axum. It additionally provides a ready-to-use conversion webhook server.This PR does not include code for TLS cert auto-generation and as such doesn't support it (marked with
todo!()). The code for this feature will be handled by a follow-up PR. Furthermore, the code for TLS cert chains will also move into the new crate.